[OpenSIPS-Devel] [ opensips-Bugs-2994156 ] osipsconsole and PID file
SourceForge.net
noreply at sourceforge.net
Sun Aug 1 21:41:49 CEST 2010
Bugs item #2994156, was opened at 2010-04-29 16:04
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2994156&group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tools
>Group: 1.6.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: ledda (ledda)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: osipsconsole and PID file
Initial Comment:
In osipsconsole script when checking PID given in config the code should be:
if ( -z $PID_FILE){
$PID_FILE = "/var/run/opensips.pid";
}
"if file has zero size then use /var/run/opensips.pid".
Right now its: if file has NON zero size (given in config) then use /var/run/opensips.pid, which is wrong.
Also there is a sense to verify other usage of "!-z" course same incorrect logic may be used in other parts of the script too.
E.g. this code also looks suspicious:
if ( !-z $ETCDIR ) {
$ETCDIR=$PATH_ETC."/opensips";
}
----------------------------------------------------------------------
>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-08-01 22:41
Message:
Also fixed!
Thanks and regards,
Bogdan
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2994156&group_id=232389
More information about the Devel
mailing list