[OpenSIPS-Devel] [ opensips-Bugs-2994156 ] osipsconsole and PID file

[SourceForge.net]

Bugs item #2994156, was opened at 2010-04-29 16:04
Message generated for change (Tracker Item Submitted) made by ledda
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2994156&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tools
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ledda (ledda)
Assigned to: Nobody/Anonymous (nobody)
Summary: osipsconsole and PID file

Initial Comment:
In osipsconsole script when checking PID given in config the code should be:

if ( -z $PID_FILE){
        $PID_FILE = "/var/run/opensips.pid";
}

"if file has zero size then use /var/run/opensips.pid".

Right now its: if file has NON zero size (given in config) then use /var/run/opensips.pid, which is wrong.

Also there is a sense to verify other usage of "!-z" course same incorrect logic may be used in other parts of the script too.
E.g. this code also looks suspicious:
if ( !-z $ETCDIR ) {
        $ETCDIR=$PATH_ETC."/opensips";
}


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2994156&group_id=232389