[OpenSIPS-Devel] [ opensips-Bugs-2993101 ] client_nat_test(1) checks first Contact only

[SourceForge.net]

Bugs item #2993101, was opened at 2010-04-27 19:03
Message generated for change (Tracker Item Submitted) made by thomas_gelf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2993101&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Gelf (thomas_gelf)
Assigned to: Nobody/Anonymous (nobody)
Summary: client_nat_test(1) checks first Contact only

Initial Comment:
Test #1 from nat_traversal's client_nat_test() seems to check only the very first Contact in a SIP header. I stumbled over this as I got (legal) REGISTER requests from a Windows-based SIP/T.38 stack containing 8 (!!) Contacts, one for each local interface, all of them with different q-values. As one of them has been the correct public socket, it could happen from time to time, that save() stored the other location records with their private IPs, as received_avp has not been set: client_nat_test(7) didn't match.

As I see no way to handle each contact individually with current OpenSIPS functions, I'd suggest to return true if just one single Contact matches, regargless of its position.

Regards,
Thomas Gelf


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2993101&group_id=232389