[OpenSIPS-Devel] [ opensips-Bugs-2980529 ] large xml bodies due to spaces

[SourceForge.net]

Bugs item #2980529, was opened at 2010-04-01 14:42
Message generated for change (Settings changed) made by wdoekes
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2980529&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
>Group: 1.6.x
Status: Open
Resolution: None
>Priority: 3
Private: No
Submitted By: Walter Doekes (wdoekes)
Assigned to: Nobody/Anonymous (nobody)
Summary: large xml bodies due to spaces

Initial Comment:
Hi,

after the new updates to OpenSIPS 1.6.x, I'm back again trying to get BLF to work properly in my setup.

When the presence_dialoginfo force_single_dialog is set to 0 I get very large NOTIFY's (so large that my phone cannot handle it). This is probably due to some cleanup action not happening. But, while investigating this, I notice that a lot of bytes get wasted on XML formatting. Unfragmented UDP should be at most 1500 bytes or so (depending on the MTU) and the dialoginfo messages get there very quickly.

I suggest removing the excess space from these verbose XML messages. The fix is simple: replace the 1 with a 0 in the xmlDocDumpFormatMemory calls.

See the attached patch.

Regards,
Walter Doekes
OSSO B.V.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2980529&group_id=232389