[OpenSIPS-Devel] [ opensips-Bugs-2858331 ] nat_bflag shall be branch-aware

[SourceForge.net]

Bugs item #2858331, was opened at 2009-09-14 02:41
Message generated for change (Comment added) made by thomas_gelf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2858331&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: nat_bflag shall be branch-aware

Initial Comment:
As it is called a branch flag, nat_bflag shall IMO be branch_aware ;-)
Test scenario:

* REGISTER two UACs, one of them with and the other one without NAT issue
* check your location table (cflags, received)
* Place a call, log the branch flag

You will see, that if one branch has the flag set, it is also true for
the other branch. Tested with r6115.

Best regards,
Thomas Gelf


----------------------------------------------------------------------

Comment By: Thomas Gelf (thomas_gelf)
Date: 2009-09-15 16:35

Message:
No, branch flags are fine. What I discovered was the following:

During a REGISTER request, I'm doing my NAT checks and set bflag_nat
if able to detect such an issue.

A location lookup call will then set this flag on calls for this
specific location. However, if one user is registered multiple times,
and only one of them has this flag set in location table, lookup()
applies the flag to each branch - while it should only be set on those
really having a NAT issue.

Best regards,
Thomas Gelf


----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-09-14 22:15

Message:
Hi Thomas, you mean the branch flags are not different in each branch ?
(even if initially , each branch had a different set of branch fags? )

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2858331&group_id=232389