[OpenSIPS-Devel] [ opensips-Patches-2858251 ] enable manual result polling of benchmarks and more...

[SourceForge.net]

Patches item #2858251, was opened at 2009-09-13 23:42
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2858251&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Stanislaw Pitucha (viraptor)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: enable manual result polling of benchmarks and more...

Initial Comment:
Changes to the benchmark module:
- allow granularity == 0 (disables automatic logging)
- add bm_poll_results MI command (poll current results and restart local counters)
- reject granularity < 0
- add per-timer locking where needed (only reset, bm_log_timer and MI really)
- cleanup (save the 'timer' value, instead of repeating 'bm_mycfg->tindex[i]')
- code nazi (add 'static' to all not exported functions)
- remove reset_timers, because it was neither exported in .h, not used internally
- updated documentation with new entries

patch against trunk-r6115

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-09-14 22:52

Message:
Hi Stan,

The patch looks fine (as functionality and code), so I uploaded it on
SVN.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Stanislaw Pitucha (viraptor)
Date: 2009-09-13 23:45

Message:
Forgot to add the reason for manual polling (it's included in the docs
though): that way you can use munin / cacti / some other tool to make a
continuous graph from the benchmarks, instead of tail'ing logs, or using
some other methods.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2858251&group_id=232389