[OpenSIPS-Devel] [ opensips-Patches-2872048 ] warnings and error messages

[SourceForge.net]

Patches item #2872048, was opened at 2009-10-03 00:35
Message generated for change (Comment added) made by viraptor
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2872048&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: trunk
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Stanislaw Pitucha (viraptor)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: warnings and error messages

Initial Comment:
Trivial cleanup changes:
- removed warnings when compiling action and modules/ratelimit
- improved error reporting on missing modules
- added some syntax error problem guessing

----------------------------------------------------------------------

>Comment By: Stanislaw Pitucha (viraptor)
Date: 2009-10-12 03:42

Message:
That's for warning elimination / potential bugfix.
My gcc (4.3.3) warns that format should be a literal string. It seems
that:
log(ERR, "%s%s%s%s%s%s");
or something similar might explode (it will be used as the format string).

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-10-12 01:17

Message:
what is about this replacement :

-			LM_GEN1(a->elem[0].u.number, a->elem[1].u.string);
+			LM_GEN1(a->elem[0].u.number, "%s", a->elem[1].u.string);

I would say it is the same ?

The rest of the patch was applied.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2872048&group_id=232389