[OpenSIPS-Devel] [ opensips-Bugs-2788937 ] presence: Wrong Subscription-State "expires" value in NOTIFY

[SourceForge.net]

Bugs item #2788937, was opened at 2009-05-08 14:57
Message generated for change (Comment added) made by anca_vamanu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2788937&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Iñaki Baz Castillo (ibc_sf)
Assigned to: Anca Vamanu (anca_vamanu)
Summary: presence: Wrong Subscription-State "expires" value in NOTIFY

Initial Comment:
OpenSIPS "presence" module is generating really wrong "expires" values in "Subscription-State" header of NOTIFY. This causes the subscriber thinking that the subscription lives for long time (due to the exagerate high value of "expires" parameter) but the fact is that the subscriber dissapears from "active-watchers" table and leaves getting notifications.

I just use (these are really low values for testing, but the issue also occurs with higher values):

------------
modparam("presence", "max_expires_publish", 50)
modparam("presence", "max_expires_subscribe", 20)
modparam("presence", "expires_offset", 5)
modparam("presence", "fallback2db", 1)
------------

I attach a capture. Note in line 376 how the "Subscription-State" has a "cool" value:

  Subscription-State: active;expires=4294967285  <---- !!!!!!!!!!!!!

----------------------------------------------------------------------

>Comment By: Anca Vamanu (anca_vamanu)
Date: 2009-05-11 13:21

Message:
Hi,

I have tested myself and found the bug. I have committed a fix. Please
update and test.
I will close this bug report, but if you notice the problem again you can
reopen it. 

Thanks and regards,
Anca 

----------------------------------------------------------------------

Comment By: Iñaki Baz Castillo (ibc_sf)
Date: 2009-05-08 16:50

Message:
Here there is a sequence of "Subscription-State" header value in NOTIFY's
generated by presence module. There are just two subscribers, one of them
uses "expires=600" and the other "expires=3600". "max_expire_subscribe" is
set to 3600 in OpenSIPS presence module.

Subscription-State: active;expires=658
Subscription-State: active;expires=484
Subscription-State: active;expires=658
Subscription-State: active;expires=484
Subscription-State: active;expires=657
Subscription-State: active;expires=657
Subscription-State: active;expires=483
Subscription-State: active;expires=483
Subscription-State: active;expires=437
Subscription-State: active;expires=263
Subscription-State: active;expires=437
Subscription-State: active;expires=263
Subscription-State: active;expires=399
Subscription-State: active;expires=225
Subscription-State: active;expires=399
Subscription-State: active;expires=225
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=600
Subscription-State: active;expires=600
Subscription-State: active;expires=138
Subscription-State: active;expires=138
Subscription-State: active;expires=4294967260   <--- !!!
Subscription-State: active;expires=4294967260   <--- !!!
Subscription-State: active;expires=150
Subscription-State: active;expires=150
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=3600
Subscription-State: active;expires=4294967279   <--- !!!
Subscription-State: active;expires=4294967279   <--- !!!
[...]

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2788937&group_id=232389