[OpenSIPS-Devel] [ opensips-Patches-2786818 ] fix: cpl - priority not set correctly when Q_UNSPECIFIED

[SourceForge.net]

Patches item #2786818, was opened at 2009-05-04 22:34
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2786818&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.5.x
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: John Riordan (john_riordan)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: fix: cpl - priority not set correctly when Q_UNSPECIFIED

Initial Comment:
CPL "lookup" is not checking for the possibility that a contact's q-value could be Q_UNSPECIFIED when setting a locations "priority".

The patch adds this check and sets the priority to "1.0" in accordance with RFC3880 (CPL)
...
Section 5.1
...
"The optional "priority" parameter specifies a priority for the
location.  Its value is a floating-point number between 0.0 and 1.0.
If it is not specified, the server SHOULD assume a default priority
of 1.0."
...
Section 6.1.1
...
"SIP servers SHOULD honor the "q" parameter of SIP registrations when
determining location priority."


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-05-05 13:49

Message:
Hi John,

Thanks for the patch - I applied it on trunk, 1.5 and 1.4 OpenSIPS
versions.

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2786818&group_id=232389