[OpenSIPS-Devel] SF.net SVN: opensips:[5847] trunk/modules/nat_traversal/nat_traversal.c

[Bogdan-Andrei Iancu]

Hi Dan,

I agree that the fix I made was fixing an effect and not the real cause, 
but this was preventing the crashing until the real cause is found and 
fixed. The crashing was reported by Thomas Gelf ( he got 4G od core 
files during a night), so I'm not sure if it safe to remove this fix 
without having the real fix in place - if not, we will simple expose the 
users to more crashes.

Regards,
Bogdan

Dan Pascu wrote:
> Revision: 5847
>           http://opensips.svn.sourceforge.net/opensips/?rev=5847&view=rev
> Author:   dan_pascu
> Date:     2009-07-09 04:11:28 +0000 (Thu, 09 Jul 2009)
>
> Log Message:
> -----------
> Rollback changes made in revisions #5783 and #5784
>
> Those changes do not solve any problem, they only hide the error by not
> sending anymore keepalive messages to the affected endpoints. In reality
> contact->uri should always be sip:IP:port so no extra checks are required.
> The port is always present even when default and the uri is built from the
> msg->rcv structure so it doesn't depend on any user setting from the script.
>
> Modified Paths:
> --------------
>     trunk/modules/nat_traversal/nat_traversal.c
>
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>