[OpenSIPS-Devel] [ opensips-Patches-2478793 ] Allow MI command to return all values under a profile

[SourceForge.net]

Patches item #2478793, was opened at 2008-12-31 12:25
Message generated for change (Comment added) made by rrevels
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2478793&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.4.x
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Richard Revels (rrevels)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Allow MI command to return all values under a profile

Initial Comment:
This is a small patch to check for the value of "all" when using the MI command profile_get_size.  We needed it for the case where we want to know how many dialogs are up for each value but did not want to have to run the MI command multiple times.

opensipsctl fifo profile_get_size inbound all


----------------------------------------------------------------------

Comment By: Richard Revels (rrevels)
Date: 2009-01-29 03:31

Message:
Uploaded new diff file.  This was also created against 1.4 revision 5055. 
The patch should be applied after changing to the modules/dialog directory.

Usage:
opensipsctl fifo profile_get_values outbound

Will return list of values assigned to outbound profile with dialog count
in each.  Also prints summary count of all values.

----------------------------------------------------------------------

Comment By: Richard Revels (rrevels)
Date: 2009-01-09 19:37

Message:
I thought about that and decided it wasn't a problem.  Guess I should have
thought about it a little more.  I was planning to work on an update this
weekend.  I'll change it to a new function at the same time.

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-01-09 10:02

Message:
Hi Richard,

I agree with Ovidiu - better make a new function to avoid conflicts
between values and keyword.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2009-01-05 16:51

Message:
This patch will make 'all' a restricted value for a profile.
I would rather have a new mi command for returning all values (like
profile_get_vsize).

Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Richard Revels (rrevels)
Date: 2009-01-04 16:43

Message:
Added a second patch file which correctly returns all values within each
hash rather than just the first one.  The next step will be to have the new
function return counts rather than calling get_profile_size in a loop.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2478793&group_id=232389