[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

[Juha Heinanen]

Adrian Georgescu writes:

 > You can subscribe also to users of remote domains and they are not  
 > local.

sure, but in that case, i'm not calling handle_subscribe, but just
t_relay the request.

 > >  so if target of
 > > subscribe is not for a local user, handle it with rls_handle_subscribe
 > > and return 404 if it fails.
 > 
 > This is wrong for the reason above.

sorry, i meant, user part of uri does not belong to existing user, but
host part is a local domain.

 > There was a reason for handling the way it was, too bad Dan is in  
 > holiday and could not comment.

the way it was does not work if you plan to call handle_subscribe after
rls_handle_subscribe.

there is two possible implementations of rls_handle_subscribe:

- do not do any smarts in the implementation, but leave it to the script
  to figure out when to call rls_subscribe

- do smarts the way they are done now

they way the smarts were done earlier, was not correct.

-- juha