[OpenSIPS-Devel] [ opensips-Patches-2828870 ] Add Call-Id to failed radius accounting log

[SourceForge.net]

Patches item #2828870, was opened at 2009-07-29 11:47
Message generated for change (Comment added) made by cupotka2008
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2828870&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.5.x
Status: Open
Resolution: None
Priority: 4
Private: No
Submitted By: Alex Massover (cupotka2008)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Add Call-Id to failed radius accounting log

Initial Comment:
Hi!

This patch adds Status and Call-Id to failed radius accounting request. The purpose is to be able to track such failed request.

Please see if 
rd_vals[r_status-1].n
is a good way to get Status.

The patch is against 1.5.2 (tested on 1.4.3).

Alex Massover & Dror Wald

----------------------------------------------------------------------

>Comment By: Alex Massover (cupotka2008)
Date: 2009-08-05 10:19

Message:
Hi!

It's complete, I tested it. 

Currently when radius acc request fails it writes in the log:
LM_ERR("radius-ing failed\n");
In production there's no way to track for which call radius-acc failed.
The idea of the patch is to have status (start/stop/failed/alive) and the
Call-ID in this log, like this:
LM_ERR("Radius accounting request failed for status: '%s' Call-Id: '%.*s'
\n",r_stat->n,req->callid->body.len,req->callid->body.s);



----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-08-05 01:44

Message:
Hi Alex,

Please check if the patch you uploaded is complete or not - my first
feeling (when looking) is that something is some part of it is missing, In
the current form it make not much sense.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Alex Massover (cupotka2008)
Date: 2009-07-30 11:47

Message:
New patch uploaded, this one works. It's dirty, probably requires a closer
look by a specialist.

----------------------------------------------------------------------

Comment By: Alex Massover (cupotka2008)
Date: 2009-07-30 10:32

Message:
Removed patch, doesn't work on 1.5.2 (worked for 1.4.3). Investigating.

----------------------------------------------------------------------

Comment By: Alex Massover (cupotka2008)
Date: 2009-07-29 11:51

Message:
This patch adds Status and Call-Id to failed radius accounting request
_LOG_.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2828870&group_id=232389