[OpenSIPS-Devel] SF.net SVN: opensips:[5933] branches/1.5

[Bogdan-Andrei Iancu]

I thought of this in the first thing, but (as documented), if the the 
port or proto is missing, the grep function assumes ANY and not a 
default value. And actually the function is used in other part with the 
ANY behaviour.

Regards,
Bogdan

Dan Pascu wrote:
> On Tuesday 04 August 2009, Bogdan-Andrei Iancu wrote:
>   
>> Revision: 5933
>>           http://opensips.svn.sourceforge.net/opensips/?rev=5933&view=rev
>> Author:   bogdan_iancu
>> Date:     2009-08-04 16:45:55 +0000 (Tue, 04 Aug 2009)
>>
>> Log Message:
>> -----------
>> backport from trunk (rev #5916):
>> - fixed setting default values for SIP port and proto when greaping for a 
>> socket; the function ignore the port / proto if zero, but the parsing 
>> functions set them to 0 if they do not exist (in uris).
>>     
>
> Wouldn't it be better if the parsing function would return the correct default 
> ports based on protocol, when missing, instead of returning 0 and requiring 
> the user to call another macro after that just to fix it?
>
>   
>>   Closes bug id #2827960
>>   Credits go to Peter Baer.
>>
>> Revision Links:
>> --------------
>>     http://opensips.svn.sourceforge.net/opensips/?rev=5916&view=rev
>>
>> Modified Paths:
>> --------------
>>     branches/1.5/modules/nat_traversal/nat_traversal.c
>>     branches/1.5/modules/registrar/save.c
>>     branches/1.5/modules/rr/loose.c
>>     branches/1.5/modules/tm/mi.c
>>     branches/1.5/pvar.c
>>     branches/1.5/socket_info.h
>>
>>
>> This was sent by the SourceForge.net collaborative development platform, the 
>>     
> world's largest Open Source development site.
>   
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>
>>
>>     
>
>
>