[OpenSIPS-Devel] [ opensips-Bugs-2076632 ] nathelper causing SIP syntax error

[SourceForge.net]

Bugs item #2076632, was opened at 2008-08-26 23:14
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2076632&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Closed
>Resolution: Fixed
Priority: 7
Private: No
Submitted By: Norm Brandinger (norm_brandinger)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: nathelper causing SIP syntax error

Initial Comment:
The following section of a trace shows that there is an extra CRLF in front of the nortpproxy line.

There was some new logic recently added to nathelper.c around line 1672 that might have caused this problem

<snip>
Call-ID: MzQwM2M4NTAyYTJmZDRiNjAyYzRiYTMwODMwNzFjZDg..
CSeq: 2 INVITE.
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, NOTIFY, MESSAGE, SUBSCRIBE, INFO.
Content-Type: application/sdp.
User-Agent: X-Lite release 1014k stamp 47051.
Content-Length: 380.
.
v=0.
o=- 0 2 IN IP4 192.168.1.198.
s=CounterPath X-Lite 3.0.
c=IN IP4 74.55.77.234.
t=0 0.
m=audio 35042 RTP/AVP 100 106 0 105 98 8 3 101.
a=fmtp:101 0-15.
a=rtpmap:100 SPEEX/16000.
a=rtpmap:106 SPEEX-FEC/16000.
a=rtpmap:105 SPEEX-FEC/8000.
a=rtpmap:98 iLBC/8000.
a=rtpmap:101 telephone-event/8000.
a=alt:1 1 : YP2JqA3O Sml1xtrX 192.168.1.198 1562.
a=sendrecv.
.a=nortpproxy:yes.

</snip>

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-09-01 21:33

Message:
Logged In: YES 
user_id=1275325
Originator: NO

The fix is available on trunk and 1.4 branch. If some other issues are
still present, please re-open the bug.

Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-08-30 17:46

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Norm,

I suspect that the garbage 0 is actually received - I'm testing a patch
that uses the body len from the Content-Length instead of computing based
on the package size - this will exclude any extra garbage attached to the
package.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Norm Brandinger (norm_brandinger)
Date: 2008-08-27 15:39

Message:
Logged In: YES 
user_id=1786021
Originator: YES

Bogdan,

Sorry, all I currently had was a ngrep trace.  Going to have to build up a
test environment in order to get a pcap capture to you (because the proxy
that produced the problem was downgraded).

Regards,
Norm

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-08-27 15:26

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Norm,

Do you have a pcap with such an SDP (causing problems to nathelper)  ? I
want to run some tests....

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Norm Brandinger (norm_brandinger)
Date: 2008-08-27 15:04

Message:
Logged In: YES 
user_id=1786021
Originator: YES

Bogdan,

Yes,  that change appears to be where the new logic was introduced.

In my environment, it's causing problems.  

I've found that some proxies are more forgiving to this than others (some
accept this request and others reject it). This may explain why the issue
was not immediately detected by the community.

Regards,
Norm


----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-08-27 14:49

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Norman,

You refer to this change ?
http://opensips.svn.sourceforge.net/viewvc/opensips?view=rev&revision=4262

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2076632&group_id=232389