[OpenSIPS-Devel] [ opensips-Bugs-2202094 ] PUA_BLA requires "Subscription-State" case sensitive

[SourceForge.net]

Bugs item #2202094, was opened at 2008-10-27 23:48
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2202094&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Iñaki Baz (ibc_sf)
Assigned to: Nobody/Anonymous (nobody)
Summary: PUA_BLA requires "Subscription-State" case sensitive

Initial Comment:
pua_bla requires "Subscription-State" header being case sensitive.

When I send a NOTIFY with:
  Event: dialog;sla
  Subscription-state: active;expires=2009

pua_bla says:
  ERROR:pua_bla:bla_handle_notify: No Subscription-State header found

This doesn't occur if I send "Subscription-State".

Of course this is a bug since SIP syntax defines header names as case insensitive.

I see in notify.c code:

       while (hdr!= NULL)
        {
                if(strncmp(hdr->name.s, "Subscription-State",18)==0 )
                {
                        found = 1;
                        break;
                }
                hdr = hdr->next;
        }
        if(found==0 )
        {
                LM_ERR("No Subscription-State header found\n");
                goto error;
        }

AFAIK the above comparision based on "strncmp" is case sensitive so it breaks SIP syntax.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2202094&group_id=232389