[OpenSIPS-Devel] [ opensips-Patches-2101086 ] Multiple DB support for avpops module

[SourceForge.net]

Patches item #2101086, was opened at 2008-09-09 02:36
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2101086&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Kobi Eshun (ekobi)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Multiple DB support for avpops module

Initial Comment:
Hi.

Attached is a patch implementing extended DB support for the avpops module. The patch adds a new module parameter, 'dbx_url', and a new script function, 'avp_dbx_query(index, query [,dest]).

The patch includes updates to the module docs to describe the new functionality.

Cheers,
--
kobi

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-12-31 00:34

Message:
Hi Kobi,

I had to rework a bit your patch before uploading it on SVN, mainly to
make its integration more transparent (no extra functions or params) and
also to fix some issues with binding to multiple DB backends.

Main changes:
-all DB URLS are specified via db_url param which accepts the old format
and the index format
-index is now internally just a label and not an array index
-all avp_db_** functions accept an extra optional param to indicate a
specific DB  support.

I would appreciate if you could test the new version.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Kobi Eshun (ekobi)
Date: 2008-09-23 22:18

Message:
File Added: avpdbx.patch

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-09-09 16:05

Message:
Hi Kobi,

yes, access to multiple DBs make sense - I will review the patch and come
back to you.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Kobi Eshun (ekobi)
Date: 2008-09-09 11:35

Message:
The "extended DB support" permits queries against multiple databases. The
existing code restricts all avp_db_query() calls to be against the same DB
URL. This is inconvenient when you want to migrate your database tables to
different servers for performance tuning reasons, for example. This patch
removes the restriction.

If this concept is generally useful, I'd be open to refactoring the code
to fit in more smoothly with the existing. For example, I maintain a vector
of DB URLs separately from the existing DB URL. There is no conceptual
reason to keep it this way. It might also be possible to eliminate the new
script function altogether, and overload the existing signature to handle
an optional DB index.

--
kobi

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-09-09 11:12

Message:
Hi Kobi,

Thanks for the patch - could you detail a bit what means the "extended" DB
support ?

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2101086&group_id=232389