[OpenSIPS-Devel] [ opensips-Patches-2351140 ] [nat_traversal] Making OPTIONS/NOTIFY lighter

[SourceForge.net]

Patches item #2351140, was opened at 2008-11-26 17:09
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2351140&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Open
>Resolution: None
Priority: 5
Private: No
Submitted By: Iñaki Baz (ibc_sf)
Assigned to: Dan (dan_pascu)
Summary: [nat_traversal] Making OPTIONS/NOTIFY lighter

Initial Comment:
I attach a patch that makes NOTIFY/OPTIONS sent by "send_keepalive()" function lighter. Basically I use short header names and make shorter the Call-Id.

The original message has ~ 252 chars.
The modified message has ~ 198 chars.

Not too much anyway. I wonder if the server_IP could also be replaced in From and To headers, and use "nat" as hostpart or whatever.

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-12-04 14:39

Message:
Dan,

maybe re-using the short naming of the headers (without changing the
callid) will spare some bandwidth - if you consider the amount of pings and
how often you do it.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Dan (dan_pascu)
Date: 2008-11-27 10:52

Message:
The gain is size is minimal and doesn't justity the loss of readability.
Plus by changing the way you build the call-id you made it impossible for
it to identify the replies.


----------------------------------------------------------------------

Comment By: Iñaki Baz (ibc_sf)
Date: 2008-11-26 17:25

Message:
Humm, I've realized that my patch causes an error:

  ERROR:core:forward_reply: no 2nd via found in reply

I don't see that error. It occurs when OpenSIPS sends (sucesfully) the
keepalive NOTIFY and the user replies:

-------------
NOTIFY sip:USER_IP:62356 SIP/2.0
v: SIP/2.0/UDP PROXY_IP:5060;branch=0
f: sip:keepalive at PROXY_IP;tag=e3e052d
t: sip:USER_IP:62356
i: 28d6327a
CSeq: 1 NOTIFY
Event: keep-alive
l: 0


SIP/2.0 400 Contact header missing
Via: SIP/2.0/UDP PROXY_IP:5060;branch=0
To: <sip:USER_IP:62356>;tag=giwjk
From: <sip:keepalive at PROXY_IP>;tag=e3e052d
Call-ID: 28d6327a
CSeq: 1 NOTIFY
Server: Twinkle/1.3
Content-Length: 0
------------


What could be the problem? does it really exist?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2351140&group_id=232389